Compat IrrationalConstants.jl to 0.2, avoiding type privacy #97
+15
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the type work around discussion here JuliaMath/IrrationalConstants.jl#43. |
|
Could you also bump the patch version of this package? That way, I'll merge and tag |
|
👍 ci failed because they are outdated, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Base.@irrationalin packages is known to have type privacy (JuliaLang/julia#46531), so IrrationalConstants.jl introduces a new macro in JuliaMath/IrrationalConstants.jl#19 . This update would avoid name collision of multiple defined_sqrt3by4piand_sqrt3by2pi. It should be worthy to avoid type piracy as possible.