-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup custom key bindings for windows/linux #3
Conversation
@yckart I only did not set them up because the keys I wanted to use ( cmd ) does not exist in Win/Lin and wasn't sure what key combo to use as an alternative. If you would like to make a pull request I would accept it. I am already setting the key command for |
@yckart I am so sorry I missed this, I will gladly merge this in, would you mine making the following changes first:
|
@jisaacks Sorry, for the delay! I thought right now a bit about that topic (bindings) and have to say, that we should re-map them. I don't really like the switch between So, what do you think about a change? |
Yeah that sounds fine. |
Cuts the key binding differences between mac, windows and linux.
Setting up bindings for |
Closes #3 Fixes #9 The currently used `ctrl+shift+enter` is already assigned to the `add_line_before` command in Sublime Text 3's Default package. This commit resolves this conflict by binding the `max_pane` command to MacOS: `super+k`, `super+f` Windows/Linux: `ctrl+k`, `ctrl+f` as 1) this binding is not currently used by vanilla ST3 or Origami plugin. 2) the sequence ctrl+k, ctrl+... is used for various pane and layout related functions like `focus_neighbouring_group`, `move_to_neighbouring_group` or `toggle_sidebar` in Sublime Text or Origami plugin. Note: The key bindings for `shift_pane` and `unshift_pane` on MacOS are kept unchanged for compatibility reasons with ST2 and iTerm behavior. New bindings for Linux/Windows are not added because ST3 provides these functions and proper bindings out of the box, which deprecates both functions.
As you documented, we (windows/linux users) have to define our own key bindings to navigate through panes.
But why do we have to? ctr+alt+... is not used by windows nor st2. Or are there any other thoughts I've missed?