Skip to content

Commit

Permalink
ash: Update window frame art and transparency values
Browse files Browse the repository at this point in the history
Per kuscher@ we'd like to try:
* Active and inactive windows 100% opaque
* Solo window 30% opaque
* New art assets for active and inactive window frames

BUG=137340
TEST=visual, with 2 windows open the active window should have an opaque darker frame and the inactive window should have an opaque lighter frame

Review URL: https://chromiumcodereview.appspot.com/10825086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149006 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jamescook@chromium.org committed Jul 30, 2012
1 parent 3322792 commit 109acb8
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions ash/wm/frame_painter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ bool IsVisibleNormalWindow(aura::Window* window) {
namespace ash {

// static
int FramePainter::kActiveWindowOpacity = 230; // "Linus-approved" values
int FramePainter::kInactiveWindowOpacity = 204;
int FramePainter::kSoloWindowOpacity = 51;
int FramePainter::kActiveWindowOpacity = 255; // 1.0
int FramePainter::kInactiveWindowOpacity = 255; // 1.0
int FramePainter::kSoloWindowOpacity = 77; // 0.3
std::set<FramePainter*>* FramePainter::instances_ = NULL;

///////////////////////////////////////////////////////////////////////////////
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions chrome/app/theme/theme_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,8 @@
</if>
<if expr="pp_ifdef('use_ash')">
<!-- Ash has a gray frame, Windows uses blue. -->
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME" file="ash/theme_frame_default_active.png" />
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME_INACTIVE" file="ash/theme_frame_default_inactive.png" />
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME" file="ash/theme_frame_active.png" />
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME_INACTIVE" file="ash/theme_frame_inactive.png" />
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME_INCOGNITO" file="ash/theme_frame_incognito_active.png" />
<structure type="chrome_scaled_image" name="IDR_THEME_FRAME_INCOGNITO_INACTIVE" file="ash/theme_frame_incognito_inactive.png" />
</if>
Expand Down

0 comments on commit 109acb8

Please sign in to comment.