Get rid of initialMetricsEnabled

The observer function is already passed the new and old values, we just didn't use them.
jinrenjie · Apr 17, 2019 · da7829c · da7829c
1 parent eb64ab8
commit da7829c
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/server_manager/ui_components/outline-server-settings.html b/src/server_manager/ui_components/outline-server-settings.html
@@ -172,7 +172,6 @@ <h3>Share anonymous metrics</h3>
       update: function(name, metricsEnabled) {
         this.initialName = name;
         this.name = name;
-        this.initialMetricsEnabled = metricsEnabled;
         this.metricsEnabled = metricsEnabled;
       },
       _handleNameInputKeyDown: function(event) {
@@ -195,15 +194,14 @@ <h3>Share anonymous metrics</h3>
           this.fire('ServerRenameRequested', {newName});
         }
       },
-      _metricsEnabledChanged: function() {
-        if (this.metricsEnabled === undefined || this.initialMetricsEnabled === undefined) {
+       _metricsEnabledChanged: function (newMetricsEnabled, oldMetricsEnabled) {
+        if (oldMetricsEnabled === undefined || newMetricsEnabled === undefined) {
           return;
         }
         // Fire signal if metrics changed.
-        if (this.metricsEnabled !== this.initialMetricsEnabled) {
-          const metricsSignal = this.metricsEnabled ?
-              'EnableMetricsRequested' : 'DisableMetricsRequested';
-          this.initialMetricsEnabled = this.metricsEnabled;
+        if (newMetricsEnabled !== oldMetricsEnabled) {
+          const metricsSignal = newMetricsEnabled ?
+            'EnableMetricsRequested' : 'DisableMetricsRequested';
           this.fire(metricsSignal);
         }
       },