Skip to content

Ability to disable JinjaCpp installation rules - #250

Merged
rmorozov merged 2 commits into
jinja2cpp:masterfrom
ilya-lavrenov:jinja-installation-rules
May 24, 2024
Merged

rmorozov merged 2 commits into
jinja2cpp:masterfrom
ilya-lavrenov:jinja-installation-rules

Conversation

@ilya-lavrenov

@ilya-lavrenov ilya-lavrenov commented May 10, 2024 •

Copy link
Copy Markdown
Contributor
  • When JinjaCpp is build as sub-project and used as static library, installation rules are not required. It's a good practice to disable installation rules when project is used as a subproject.
  • Secondly, cloning of boost repository takes a while, while download archive is more compact and fast way.
  • Migrated to new 1.85 boost version, which does not require patching

@ilya-lavrenov

Copy link
Copy Markdown
Contributor Author

Hi @rmorozov
Could you please review?

@rmorozov

Copy link
Copy Markdown
Member

@ilya-lavrenov , sure, could you please fix CI errors?

If you don't have access to info about errors - let me know.

@ilya-lavrenov

Copy link
Copy Markdown
Contributor Author

@ilya-lavrenov , sure, could you please fix CI errors?

If you don't have access to info about errors - let me know.

I've experienced the same error locally even w/o my changes.

Is it possible to run CI on latest master to confirm it?

@rmorozov

Copy link
Copy Markdown
Member

@ilya-lavrenov , sure, could you please fix CI errors?
If you don't have access to info about errors - let me know.

I've experienced the same error locally even w/o my changes.

Is it possible to run CI on latest master to confirm it?

@ilya-lavrenov , sure, I have run it on #251

CI is green, so it seems that error connected with new changes in this PR

@ilya-lavrenov

Copy link
Copy Markdown
Contributor Author

Hi @rmorozov
I've updated the branch. Could you please run CI?

@rmorozov

Copy link
Copy Markdown
Member

@ilya-lavrenov , Seems fine now

thank you for your effort

@rmorozov
rmorozov merged commit 9ae7e1f into jinja2cpp:master May 24, 2024
@ilya-lavrenov
ilya-lavrenov deleted the jinja-installation-rules branch May 24, 2024 14:59
@ilya-lavrenov
ilya-lavrenov restored the jinja-installation-rules branch May 24, 2024 14:59
atobiszei added a commit to atobiszei/Jinja2Cpp that referenced this pull request May 28, 2024
@ilya-lavrenov
ilya-lavrenov deleted the jinja-installation-rules branch October 10, 2024 11:51
@ilya-lavrenov
ilya-lavrenov restored the jinja-installation-rules branch October 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants