Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.20 & generic test #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Antonboom
Copy link

Closes #24

Copy link

@calebeof calebeof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the rowserrcheck is running well with generics cc @jingyugao @ldez

@Antonboom
Copy link
Author

@calebeof, I think it's running well because of fresh Go and x/tools.
Can you please merge MR and make new tag?

@ldez
Copy link

ldez commented Mar 14, 2023

@Antonboom I think you misinterpreted the LGTM from @calebeof.
Based on the color (grey) of the approval, he is not a maintainer of this project.

Also, your change is just an update of libraries that are already updated in golangci-lint.
So either it already works in golangci-lint without your PR or your PR doesn't fix the problem.

@ldez
Copy link

ldez commented Mar 14, 2023

I will run my test suite with the current version of rowserrcheck inside golangci-lint and we will see.

@Antonboom
Copy link
Author

Antonboom commented Mar 14, 2023

he is not a maintainer of this project

Saw :(

So either it already works in golangci-lint without your PR or your PR doesn't fix the problem.

Yep, but I want to keep consistency between golangci-lint and standalone linter.

Anyway, so maybe you enable rowserrcheck, closes generics issue (this linter is the last one) and make new golangci-lint release (a lot of useful patches now)?

🙏

@ldez
Copy link

ldez commented Mar 14, 2023

(a lot of useful patches now)?

Not a lot, but I think we can create a version just to close the topic of generics.

I have to check some elements before creating a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSA and generics (go1.18)
3 participants