Added Click to Jump feature in the basic tag info

[gogoprog]

Hello,

Here is a useful feature when quickly browsing a SWF file

I had to convert the TagInfoPanel into a JEditorPane to support html and HyperlinkListener

[honfika]

I tried this pull request. It is sometimes buggy, first time when the tag info panel loads the last line has blue (transparent?) background. Check the image:

And my opinion is that the previous table style was much better, this is a little bit ugly...
But the idea is very good. Is it possible to add the hyperlinks to the previous java table?

[gogoprog]

Hello, thanks for trying this pr.

Indeed there seems to be a rendering issue for the first display. I'll try to find a workaround for it.

My plan was to mimic the previous style but java supports only a subset of html/css which makes the job harder.

Adding the links to the previous JTable requires hacks to know if a hyperlink is clicked because the HyperLinkEvent does not exist in this case.

But I agree it should look like it was before. I have an idea to achieve that so I'll mark this PR WIP ;)

[gogoprog]

Hi,

I just updated this PR to match the previous style.
It is not 100% the same as before but it is close to it.

Let me know what do you think!

[NuclearCookie]

This looks cool! Would be nice to have this feature merged 👍

[NuclearCookie]

@jindrapetrik Any update on this?

[gogoprog]

Same question, any update?

[NuclearCookie]

@honfika

[honfika]

Personally I don't like mixing the current "native" Java UI with HTML things, this is why I did not merge it.
I don't know what is JPEXS's opinion. Maybe he will merge it if he has no problem with it.

[jindrapetrik]

Hi, sorry for answering too late.
I tried to implement something similar based on the JTable/CellRenderer now and I confirm that it " requires hacks " for clicking the link as gogoprog said.
I think the possibility for links in taginfo panel is good idea.

For the mixing native/html: I think this new approach is better as user can select text in this table, in the previous JTable, it was not enabled/available. On the other hand, JTable had sortable columns, but I don't think anybody would want to sort columns in taginfo table. The table can have a little different look than other JTables, but it's worth it because of the links possibility.

I will appreciate an enhancement:
HTML tags for jumps should be added in the GUI part of FFDec, not in the Library.

• instead of calling Helper.getCharacterIdsHtml in Tag class, make the taginfo value raw string (character ids joined with comma as before)
• parse this value in the GUI (for example, based on taginfo name - only "neededCharacters", "dependentCharacters") and add the tags in the GUI

Is it possible to update it? (Do you still work with FFDec?)

+Do not forget to remove System.out.println(result); from TagInfoPanel

[gogoprog]

Thanks for your feedback!

I'll update it soon and yes I'm still using it ;)

[jindrapetrik]

I have switched pull request target branch, it should be dev branch instead of master branch. I hope it didn't break anything for you...

[gogoprog]

I updated it, let me know if something is wrong..

[jindrapetrik]

Looks okay to me.
Few minor notices exist in the code like comparing strings using == operator,
I will fix them after merging.
Thank you very much for your contribution!