Skip to content

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 8, 2021

close #4044

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/executor component/jaml component/peapod executor/meta labels Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #4046 (8f49561) into master (e3426b9) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4046      +/-   ##
==========================================
- Coverage   87.32%   86.72%   -0.61%     
==========================================
  Files         184      184              
  Lines       13038    13038              
==========================================
- Hits        11386    11307      -79     
- Misses       1652     1731      +79     
Flag Coverage Δ
daemon 43.22% <88.88%> (+0.02%) ⬆️
jina 86.61% <100.00%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../runtimes/request_handlers/data_request_handler.py 93.67% <ø> (+5.06%) ⬆️
jina/executors/__init__.py 85.08% <100.00%> (ø)
jina/jaml/__init__.py 95.47% <100.00%> (+0.41%) ⬆️
jina/peapods/pods/k8slib/kubernetes_tools.py 67.41% <0.00%> (-29.22%) ⬇️
jina/peapods/networking.py 58.25% <0.00%> (-28.16%) ⬇️
jina/peapods/pods/k8s.py 56.30% <0.00%> (-24.93%) ⬇️
jina/clients/base/grpc.py 66.66% <0.00%> (-13.34%) ⬇️
jina/peapods/pods/k8slib/kubernetes_deployment.py 84.00% <0.00%> (-10.67%) ⬇️
jina/clients/mixin.py 90.24% <0.00%> (-4.88%) ⬇️
jina/peapods/peas/__init__.py 85.10% <0.00%> (-1.60%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3426b9...8f49561. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1197, delta to last 2 avg.: -17%
  • 🐢🐢 query QPS at 22, delta to last 2 avg.: -22%
  • 🐢🐢 dam extend QPS at 31953, delta to last 2 avg.: -27%
  • 🐢🐢 avg flow time within 1.5451 seconds, delta to last 2 avg.: +40%
  • 🐎🐎 import jina within 0.4342 seconds, delta to last 2 avg.: +10%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1197 22 31953 1.5451 0.4342
2.5.3 1447 27 45368 1.1005 0.3826
2.5.2 1439 29 43010 1.1044 0.4024

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 7574e99 into master Dec 8, 2021
@hanxiao hanxiao deleted the fix-4044 branch December 8, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/executor component/jaml component/peapod executor/meta size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor.from_hub allow parametrization
1 participant