Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add apply and apply_batch to parallel mixin #4017

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 2, 2021

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type labels Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #4017 (fe57705) into master (db53ecc) will increase coverage by 0.99%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
+ Coverage   78.52%   79.52%   +0.99%     
==========================================
  Files         183      183              
  Lines       12911    12926      +15     
==========================================
+ Hits        10139    10280     +141     
+ Misses       2772     2646     -126     
Flag Coverage Δ
daemon 43.27% <43.75%> (-0.02%) ⬇️
jina 76.35% <43.75%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/mixins/parallel.py 32.43% <43.75%> (+5.15%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 84.61% <0.00%> (-6.84%) ⬇️
jina/peapods/stream/base.py 88.17% <0.00%> (-1.08%) ⬇️
jina/clients/base/http.py 92.68% <0.00%> (ø)
jina/peapods/runtimes/zmq/zed.py 88.12% <0.00%> (ø)
jina/peapods/zmq/__init__.py 86.51% <0.00%> (+0.23%) ⬆️
jina/types/document/__init__.py 75.26% <0.00%> (+0.69%) ⬆️
jina/helper.py 81.70% <0.00%> (+0.71%) ⬆️
jina/peapods/runtimes/grpc/__init__.py 87.50% <0.00%> (+0.78%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+0.81%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db53ecc...fe57705. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1551, delta to last 2 avg.: +31%
  • 🐎🐎🐎🐎 query QPS at 31, delta to last 2 avg.: +43%
  • 🐎🐎🐎🐎 dam extend QPS at 48160, delta to last 2 avg.: +44%
  • 🐎🐎🐎🐎 avg flow time within 1.0697 seconds, delta to last 2 avg.: -27%
  • 🐢🐢 import jina within 0.3488 seconds, delta to last 2 avg.: -24%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1551 31 48160 1.0697 0.3488
2.5.0 1201 22 35057 1.5662 0.4644
2.4.10 1163 20 31431 1.3895 0.4608

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit e5326e6 into master Dec 2, 2021
@hanxiao hanxiao deleted the feat-add-apply-batch branch December 2, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant