Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve docs #4009

Merged
merged 1 commit into from
Nov 30, 2021
Merged

fix: improve docs #4009

merged 1 commit into from
Nov 30, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Nov 30, 2021

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/type labels Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #4009 (8de16d8) into master (f6b5b5b) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
+ Coverage   88.77%   88.86%   +0.09%     
==========================================
  Files         182      182              
  Lines       12782    12782              
==========================================
+ Hits        11347    11359      +12     
+ Misses       1435     1423      -12     
Flag Coverage Δ
daemon 43.60% <ø> (+0.01%) ⬆️
jina 87.09% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/mixins/match.py 94.05% <ø> (ø)
jina/clients/base/http.py 92.68% <0.00%> (-2.44%) ⬇️
jina/peapods/runtimes/container/__init__.py 80.35% <0.00%> (-1.79%) ⬇️
jina/peapods/zmq/__init__.py 89.06% <0.00%> (-1.40%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (-0.46%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 87.17% <0.00%> (ø)
jina/helper.py 83.65% <0.00%> (+0.17%) ⬆️
jina/peapods/pods/__init__.py 85.22% <0.00%> (+0.19%) ⬆️
jina/peapods/pods/k8s.py 82.35% <0.00%> (+1.12%) ⬆️
jina/flow/base.py 93.21% <0.00%> (+1.32%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b5b5b...8de16d8. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1378, delta to last 2 avg.: +0%
  • 🐢🐢 query QPS at 23, delta to last 2 avg.: -13%
  • 🐢🐢 dam extend QPS at 38691, delta to last 2 avg.: -9%
  • 🐢🐢 avg flow time within 1.544 seconds, delta to last 2 avg.: +14%
  • 😶 import jina within 0.3939 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1378 23 38691 1.544 0.3939
2.5.0 1588 33 52130 1.4963 0.3291
2.4.10 1187 20 33167 1.196 0.4663

Backed by latency-tracking. Further commits will update this comment.

Copy link
Contributor

@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 80ad71a into master Nov 30, 2021
@JoanFM JoanFM deleted the docstring-match branch November 30, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/type size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants