Skip to content
This repository has been archived by the owner on Feb 27, 2020. It is now read-only.

"Scan Homebrew" does not recognize php-fpm #10

Merged
merged 3 commits into from
Feb 16, 2014
Merged

"Scan Homebrew" does not recognize php-fpm #10

merged 3 commits into from
Feb 16, 2014

Conversation

jimbojsb
Copy link
Owner

I am running php-fpm which I installed with homebrew. When I click "Scan Homebrew" it wont find that php-fpm is installed. I have to manually add the .plist.

@jimbojsb
Copy link
Owner

Homebrew doesn't provide PHP, I assume you installed it from a Tap?

@BNoiZe
Copy link
Author

BNoiZe commented Feb 11, 2014

Yes I did.

@jimbojsb
Copy link
Owner

I'm guessing that would be josegonzales/php. It looks like his plist doesn't conform to homebrew.mxcl.[package].plist. I see 3 choices here:

  1. do nothing, add it by hand
  2. add a special case for this tap (I'm guessing this is a very common use case)
  3. change the scan logic to assume any plist it finds in [/usr/local/]opt/packagename folder is a launchd plist

Thoughts?

@BNoiZe
Copy link
Author

BNoiZe commented Feb 11, 2014

Yes it is josegonzales/php.
I think the second solution would be the best for this case. I think many people will install PHP with homebrew if they want to use the latest PHP version.
Also choice three doesn't look like a good idea.

@loranger
Copy link

I vote for the second solution too.
Meanwhile I did added the plist manually, and it seems there an issue but I don't know if it's launchrocket related or a “josegonzales' bug” : The php service is always red when I launch my Launchrocket pref pane.
If I click the button, stop make the icon red, start make it green, but when I quit then restart the pref pane, it's red again while the service is still up.
Actually, the behaviour of php and the button are correct. Only the icon is acting weirdly.
Did someone else noticed this issue ?

@jimbojsb
Copy link
Owner

Try out this build and see if it works for you: https://dl.dropboxusercontent.com/u/896695/LaunchRocket.prefPane.gh-10.zip

I tested this by:

  1. brew tap josegonzalez/php
  2. brew install php54 --with-fpm
  3. scan home-brew with launch rocket
  4. start "php54"
  5. ps aux | grep fpm to confirm it's running

@BNoiZe
Copy link
Author

BNoiZe commented Feb 16, 2014

Tested it with php55, works like a charm!

jimbojsb added a commit that referenced this pull request Feb 16, 2014
"Scan Homebrew" does not recognize php-fpm
@jimbojsb jimbojsb merged commit 19c0a35 into master Feb 16, 2014
@jimbojsb jimbojsb deleted the gh-10 branch February 16, 2014 20:32
@loranger
Copy link

Hello,

I was waiting for the new release and realized this morning, I had to untap jimbojsb in order to get the new Formula from cask...
Anyway, I removed the previous one (launchrocket 5.1), install the 0.6 and I'm afraid it still does not work for me : http://www.youtube.com/watch?v=ZtnN5ztTQrI

@jimbojsb
Copy link
Owner

Can you please send me the logs from your Console.app? Filter by "System Preferences". Also, could you please put this in a new issue, since this one is closed.

@loranger
Copy link

Sure, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants