-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green build #64
Green build #64
Conversation
...to help track down the cause of the remaining build failures.
.github/workflows/ci.yml
Outdated
- name: Test meta-schema uri | ||
run: curl -v https://json-schema.org/draft/2019-09/schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temp step to just check the box can reach the URL
testLogging { | ||
showStandardStreams = false | ||
exceptionFormat = org.gradle.api.tasks.testing.logging.TestExceptionFormat.FULL | ||
showCauses = true | ||
showExceptions = true | ||
showStackTraces = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more logging on the build server to see what's failing.
assertThat("Errors reported not seen in reference file", extraReported, is(empty())); | ||
assertThat("Errors in reference file not reported", notReported, is(empty())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to hamcrest prints out the content of these when not empty. Which is useful for tracking down errors that only happen on the build server.
...for now.
Fix up remaining test failures to get a green build.
SchemaStoreTest
was failing formason-registry
test schemas on the build server, but run fine on my Mac. I introduced Hamcrest matches so that we can see the contents of things that are expected to be empty. Seems to be related to regular expressions. For example:Not sure whats causing this. There is a warning in my editor about redundant escape characters in the regex in
mason-registry.json
. I'm assuming the JDK used on the build server is being more strict and throwing an error, maybe. Maybe @jimblackler can decode the above errors better than me?For now, I've just disabled the three failing tests.
MetaSchemaTest
is also failing on all tests, e.g.I'm unsure why we're seeing a 403 (FORBIDDEN) here. If I add a
curl
command toci.yml
for the same URL it works just fine. Any thoughts @jimblackler ? I'd rather not disable this test if it can be avoided...