Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run known good tests as part of CI pipeline #57

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

big-andy-coates
Copy link
Collaborator

@big-andy-coates big-andy-coates commented Feb 1, 2024

Currently, the CI build on GitHub fails due to both SuiteTest and SchemaStoreTest running test cases outside of this repo.

If we are to know if contributions from others, or dependency updates from GitHub's dependabot are causing problems, we need a build that is green by default.

This PR:

  • updates SuiteTest and SchemaStoreTest to:
    • have the ability to write out the details of which tests are currently passing.
    • detect when running in CI build on GitHub and only run known good tests.
  • updates ci.yml workflow to set that its running smoke tests.
  • checks in two sets of resources, one for each test, that control which tests are known to be passing.

Currently, the CI build on GitHub fails due to both `SuiteTest` and `SchemaStoreTest` running test cases outside of this repo.

If we are to know if contributions from others, or dependency updates from GitHub's dependabot are causing problems, we need a build that is green by default.

This PR:
 - updates `SuiteTest` and `SchemaStoreTest` to:
   - have the ability to write out the details of which tests are currently passing.
   - detect when running in CI build on GitHub and only run known good tests.
 - updates `ci.yml` workflow to set that its running smoke tests.
@jimblackler
Copy link
Owner

Do we need all the empty files?

@big-andy-coates
Copy link
Collaborator Author

Yep, the presence of the file means it's a good test. The content is irrelvant.

@jimblackler jimblackler merged commit 71e7471 into jimblackler:master Feb 1, 2024
1 check failed
@big-andy-coates big-andy-coates deleted the green-build branch February 1, 2024 16:40
@big-andy-coates
Copy link
Collaborator Author

@jimblackler weirdly, still getting build failure. Which is not expected. Not sure why MetaSchemaTest is failing. Nor those two SchemaStoreTest tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants