Check for empty string on row_attrs['class'] #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #416 |
|
Thanks @Superman8218, can you also add a unit test test for this? |
|
@Superman8218 This is merged, but github doesn't agree. I also added a test in 2d81ffc |
|
released 1.4.1 |
djk2
pushed a commit
to djk2/django-tables2
that referenced
this pull request
Mar 1, 2017
This was referenced Oct 10, 2017
This was referenced Oct 30, 2017
This was referenced Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for an empty string on row_attrs['class'] allows you to assign the class attribute with a function that might return an empty string if the row doesn't meet the necessary criteria to get that particular css class.