move to Python3, add colorful annotation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
etern
commented
Jun 11, 2020
etern
commented
- Python3.6
- fix the type-then-delete-key bug, by breaking tk event chain
- use dimmer color for annotation edge, emphasize annotation text
- prompt config dialog on export
- colorful annotation
- add cursor preview when using command annotation
Changed some details.
Store config file without the json which need convet.
|
Thanks for contributing! But it still has errors in both Python 2 and 3. Could you please double-check and test your code? |
|
This PR will not compatible with Python2, if that's a problem, then this PR should be rejected, sorry for that 😟. |
|
Hi @etern, I finally got time to verify and test this pull request. Beautiful work! Many thanks for your great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.