Skip to content

Write byte length on OUT request #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

jamesadevine
Copy link
Collaborator

  • Moves socket logic for reading out data to the place where socket reads and writes are handled. This neatens up the handle_urb interface.
  • Parse the setup packet and give to handle_urb.
  • Fixes usb write does not return correct URB response #13, where the number of bytes was not set in the URB transfer response actual_length field.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4243169811

  • 22 of 34 (64.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 41.622%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 19 31 61.29%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 53.33%
Totals Coverage Status
Change from base Build 4223811826: 0.2%
Covered Lines: 544
Relevant Lines: 1307

💛 - Coveralls

@jiegec jiegec merged commit 25ece9e into jiegec:master Feb 22, 2023
@jiegec
Copy link
Owner

jiegec commented Feb 22, 2023

Invited you as a collaborator~

@jamesadevine
Copy link
Collaborator Author

Thanks! 😄

@jamesadevine
Copy link
Collaborator Author

@jiegec How do we go about generating a new release for crates.io etc.?

@jiegec
Copy link
Owner

jiegec commented Feb 22, 2023

You can login to crates.io, then I can add you to owners.

@jamesadevine
Copy link
Collaborator Author

Done!

@jamesadevine jamesadevine deleted the fix-write-response branch February 22, 2023 15:18
@jiegec
Copy link
Owner

jiegec commented Feb 22, 2023

Done!

Invited

@jamesadevine
Copy link
Collaborator Author

Version 0.6.0 published 🥳

@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 4243169811

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 39.79%

Totals Coverage Status
Change from base Build 4223811826: -1.7%
Covered Lines: 265
Relevant Lines: 666

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usb write does not return correct URB response
3 participants