Skip to content

Commit

Permalink
Merge pull request kubernetes#40619 from Random-Liu/update-kubemark-n…
Browse files Browse the repository at this point in the history
…pd-version

Automatic merge from submit-queue (batch tested with PRs 40132, 39302, 40194, 40619, 40601)

Update NPD version to v0.3.0-alpha.0 in kubemark.

@wojtek-t @shyamjvs Update the NPD version in kubemark.

I just built the alpha release https://github.com/kubernetes/node-problem-detector/releases/tag/v0.3.0-alpha.0.

And the PR kubernetes/node-problem-detector#79 is included.

However, I'm not sure whether 1 minute period is longer enough.

If it's still not longer enough, in fact we can extend it by split the resync and heartbeat:
* Every 1 minute, check whether there is inconsistency between apiserver and npd, and only update when there is inconsistency. (1 GET/m)
* Every > 2 minute, do forcibly update as heartbeat. (<0.5 PATCH/m)

And I can also make the sync period configurable after we finalize the sync mechanism.
  • Loading branch information
Kubernetes Submit Queue authored Jan 28, 2017
2 parents babecf1 + e2abfb7 commit 3a3ca50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/kubemark/resources/hollow-node_template.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
},
{
"name": "hollow-node-problem-detector",
"image": "gcr.io/google_containers/node-problem-detector:v0.3",
"image": "gcr.io/google_containers/node-problem-detector:v0.3.0-alpha.0",
"env": [
{
"name": "NODE_NAME",
Expand Down

0 comments on commit 3a3ca50

Please sign in to comment.