Skip to content

Commit

Permalink
Removed unnecessary BasicFuture wrapping
Browse files Browse the repository at this point in the history
  • Loading branch information
slisaasquatch authored and ok2c committed Mar 7, 2020
1 parent 56ef8b8 commit 99f7d2b
Showing 1 changed file with 1 addition and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import org.apache.hc.client5.http.protocol.HttpClientContext;
import org.apache.hc.core5.annotation.Contract;
import org.apache.hc.core5.annotation.ThreadingBehavior;
import org.apache.hc.core5.concurrent.BasicFuture;
import org.apache.hc.core5.concurrent.FutureCallback;
import org.apache.hc.core5.function.Supplier;
import org.apache.hc.core5.http.HttpHost;
Expand Down Expand Up @@ -122,26 +121,7 @@ public final Future<SimpleHttpResponse> execute(
final HttpContext context,
final FutureCallback<SimpleHttpResponse> callback) {
Args.notNull(request, "Request");
final BasicFuture<SimpleHttpResponse> future = new BasicFuture<>(callback);
execute(SimpleRequestProducer.create(request), SimpleResponseConsumer.create(), context, new FutureCallback<SimpleHttpResponse>() {

@Override
public void completed(final SimpleHttpResponse response) {
future.completed(response);
}

@Override
public void failed(final Exception ex) {
future.failed(ex);
}

@Override
public void cancelled() {
future.cancel(true);
}

});
return future;
return execute(SimpleRequestProducer.create(request), SimpleResponseConsumer.create(), context, callback);
}

public final Future<SimpleHttpResponse> execute(
Expand Down

0 comments on commit 99f7d2b

Please sign in to comment.