Avoid usage of jdk.jconsole module in Java 9+

[nyg]

Hello,

Since Java 9, there is a warning (illegal reflective access operation) when using the jdk.jconsole module which contains classes like LocalVirtualMachine that are used to list local VMs and attach to them. On later Java version (17?), accessing these classes makes jmxterm crash.

I implemented a Jdk9JavaProcessManager which relies only on the public Attach API (which is actually what LocalVirtualMachine appears to use under the hood, see: https://github.com/openjdk/jdk/blob/jdk8-b120/jdk/src/share/classes/sun/tools/jconsole/LocalVirtualMachine.java#L123). So my code is voluntarily based on what goes on in LocalVirtualMachine (especially when listing VMs).

I had to adapt WeakCastUtils to build the methodMap using not the from instance (which in Jdk9 case is an instance of VirtualMachineImpl which is not part of the public API) but using the "original" interface, i.e. VirtualMachine. When this distinction is not needed, I just use from.getClass().

The source and target version remain Java 8.

Also, as the mininum Java version is 8, I'm not sure it's useful to keep Jdk5JavaProcessManager.

If WeakCastUtils doesn't serve any other purpose than supporting multiple Java version, probably it could be replaced with Java 9 multi-release JARs: https://nipafx.dev/multi-release-jars-multiple-java-versions/.

Note 1: this PR includes my other PR (#112).

Note 2: as I answered in #48, making jmxterm work with Java 17+ can be done by allowing access to the jdk.jconsole module (with --add-exports jdk.jconsole/...) but this is not supported by Java 8 and cannot be used with the Java 9 --release option.

Best,
nyg

Fixes #48
Fixes #87

EDIT: I tested in the following way: compiled and ran (running jvms and open) jmxterm with both JDK8 and JDK21, but always leaving the maven.compiler.source and target to 1.8.

[tachun-shen-appier]

Did you forget to pass vm to cast?

[nyg]

Indeed I did! I created a new PR to fix that: #129.

[jluehe]

@jiaqi @nyg, have you ever seen this exception when running with JDK 21:

Exception in thread "main" java.lang.RuntimeException: Can't cast sun.tools.attach.AttachProviderImpl@272113c4: 4089615 to VirtualMachineDescriptor
        at org.cyclopsgroup.jmxterm.jdk9.Jdk9JavaProcess.startManagementAgent(Jdk9JavaProcess.java:55)
        at org.cyclopsgroup.jmxterm.SyntaxUtils.getUrl(SyntaxUtils.java:46)
        at org.cyclopsgroup.jmxterm.boot.CliMain.execute(CliMain.java:135)
        at org.cyclopsgroup.jmxterm.boot.CliMain.main(CliMain.java:41)
Caused by: java.lang.NoSuchMethodException: java.lang.Class.startLocalManagementAgent()
        at java.base/java.lang.Class.getMethod(Class.java:2395)
        at org.cyclopsgroup.jmxterm.utils.WeakCastUtils.cast(WeakCastUtils.java:43)
        at org.cyclopsgroup.jmxterm.utils.WeakCastUtils.cast(WeakCastUtils.java:116)
        at org.cyclopsgroup.jmxterm.utils.WeakCastUtils.cast(WeakCastUtils.java:81)
        at org.cyclopsgroup.jmxterm.jdk9.Jdk9JavaProcess.startManagementAgent(Jdk9JavaProcess.java:52)
        ... 3 more