Support for default source and public paths #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in https://www.gwtproject.org/doc/latest/DevGuideOrganizingProjects.html if no `source` or `public` element is defined in a module XML file, the `client` and `public` subpackage is implicitly added to the source/public path as if `<source path="client" />` or `<public path="public">` had been found in the XML.
|
From the failing tests, I can see we need to check the existence of the folders before adding them to the list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we've been using the v1 version of this plugin for about a 6 months I guess (thanks!), and we are considering moving to v2.
We have multiple GWT modules in one Gradle source set, and only one of them has an
entry-pointelement. So guessing the source path from that doesn't work for us. We could add the<source path="client"/>to all the modules, but that seems unnecessary, because:As mentioned in
https://www.gwtproject.org/doc/latest/DevGuideOrganizingProjects.html if no
sourceorpublicelement is defined in a module XML file, theclientandpublicsubpackage is implicitly added to the source/public path as if<source path="client" />or<public path="public">had been found in the XML.So, that is what this PR is about. What do you think?