Limit reading CharBuffer.array() to CharBuffer.limit() to avoid additional NULL characters at the end of some inputs #1452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not documented explicitly, but
CharBuffer.array()
"Returns the char array that backs this buffer", so the buffer may have excess space at the end that was not used for the input.(See also the explanation why https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6442955 is not a bug:
)
In a recent change to DataUtil the
array()
was passed without restricting its use to the length oflimit()
, hence adding NULL characters at the end.Fixed by passing the value of
limit()
to theCharArrayReader
that is actually reading from thearray()
.