Change Windows path separators in CMakeLists.txt #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhugman note that in the original issue, once I upgraded to 0.50.0, I had to update the package.json line as well, I provided that in the comments of that issue |
jhugman
force-pushed
the
jhugman/254-windows-path-separators
branch
from
fbd81db to
9f21523
Compare
Owner
Author
Ah, right you are. I took a step back and got cmake to do the work, rather than doing our own string munging. Would you mind testing this on Windows in your project, and reporting back? |
Johennes
approved these changes
Jun 3, 2025
Collaborator
Johennes
left a comment
Johennes
left a comment
There was a problem hiding this comment.
I cannot test this because I don't have a Windows machine but codewise it looks good. Bonus points for letting cmake wrangle the paths instead of using string manipulation. 👌
Merged
jhugman
added a commit
that referenced
this pull request
Jun 12, 2025
# 0.29.3-0 ## ✨ What's New ✨ ### 🌏🕸️ WASM! After 6 months of development, we are releasing the first version of `uniffi-bindgen-react-native` for use with WASM: - Different fixtures running: - Fixtures `chronological` and `gc-callbacks-crasher` (#238) - Fixture `async-callbacks` (#237) - Configuration file and `ubrn` command line: - Enable entrypoint and ts bindings directory to be customized for wasm (#259) - Add `ubrn build web --and-generate` command (#253) - Add CLI testing for `uniffi-bindgen-react-native` command. (#257) - Refactor of ubrn_cli into config and commands modules (#251) - `uniffi-runtime-javascript` runtime, now on `crates.io`: - Add runtimeVersion to vary version of uniffi-runtime-javascript (#256) - Prepare uniffi-runtime-javascript crate for release (#248) ## 🦊 What's Changed - Add default value for the --config option in all ubrn commands (#265) - Change Windows path separators in CMakeLists.txt (#261) - Bump `uniffi-rs` version to 0.29.3 (#267) - Bump bob & RN versions (#242) and (#260) - Run yarn pack as part of compatibility tests (#250) - Add to "who is using" section of readme (#239) - Fix wrong key name of `manifestPath` in docs (#240) ##⚠️ Breaking Changes - Bump Typescript version to 5.8, affecting `ArrayBuffer` (#271) **Full Changelog**: 0.29.0-0...0.29.3-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254 .
This copies the fix provided by @skyrover7 in unomed-dev/react-native-matrix-sdk#26.