Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete button rendering added #95

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Delete button rendering added #95

merged 3 commits into from
Sep 28, 2021

Conversation

vrose99
Copy link

@vrose99 vrose99 commented Sep 21, 2021

Delete button now only renders on collections/experiments/channels where user has permissions to do so.

@vrose99 vrose99 changed the base branch from master to integration September 21, 2021 19:32
movestill
movestill requested changes Sep 22, 2021
View reviewed changes
Copy link
Member

@movestill movestill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only called out two locations in the PR, but change use of int value that represent whether a user is an admin to a boolean to make the code more idiomatic.

django/mgmt/views.py Outdated Show resolved Hide resolved
django/mgmt/static/js/utils.js Outdated Show resolved Hide resolved
@vrose99
Copy link
Author

vrose99 commented Sep 28, 2021

Changes mentioned by Tim, above, should be reflected in the most recent commit (efa9c7b) now.

@sandyhider sandyhider merged commit e7b13d6 into integration Sep 28, 2021
@sandyhider sandyhider deleted the delete-button-rendering branch September 28, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movestill movestill movestill requested changes

@sandyhider sandyhider sandyhider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrose99 @sandyhider @movestill