Fix parsing subtitle timestamps with no hour component #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trms-alex Thanks for detailed explantation. I'll merge it with next release. |
jhomlala
added a commit
that referenced
this pull request
May 22, 2021
* Segmented ASMS subtitles loading * Skip parsing subtitle files with no cues (#492) * Fix parsing subtitle timestamps with no hour component (#491) Co-authored-by: Jakub <jhomlala@gmail.com> * General refactor, updated documentation and changelog * General refactor, updated documentation and changelog * Added spanish translation (#494) * Added spanish translation * Changed "EN VIVO" for "EN DIRECTO" Co-authored-by: Koldo <kolod@byvapps.com> * Lint fix, format, updated dependencies, general refactor * Lint fix, format, updated dependencies, general refactor * Updated changelog and normal player page * Updated iOS example configuration, updated changelog * Updated iOS example configuration, updated changelog * Fixed iOS Picture in Picture play/pause state * Format * Readme and changelog update Co-authored-by: Alex Page <50582909+trms-alex@users.noreply.github.com> Co-authored-by: Koldo <koldoru92@gmail.com> Co-authored-by: Koldo <kolod@byvapps.com>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Segmented ASMS subtitles loading * Skip parsing subtitle files with no cues (jhomlala#492) * Fix parsing subtitle timestamps with no hour component (jhomlala#491) Co-authored-by: Jakub <jhomlala@gmail.com> * General refactor, updated documentation and changelog * General refactor, updated documentation and changelog * Added spanish translation (jhomlala#494) * Added spanish translation * Changed "EN VIVO" for "EN DIRECTO" Co-authored-by: Koldo <kolod@byvapps.com> * Lint fix, format, updated dependencies, general refactor * Lint fix, format, updated dependencies, general refactor * Updated changelog and normal player page * Updated iOS example configuration, updated changelog * Updated iOS example configuration, updated changelog * Fixed iOS Picture in Picture play/pause state * Format * Readme and changelog update Co-authored-by: Alex Page <50582909+trms-alex@users.noreply.github.com> Co-authored-by: Koldo <koldoru92@gmail.com> Co-authored-by: Koldo <kolod@byvapps.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my own implementation of #486, I discovered that the library already reads in every VTT segment file and should be rendering the subtitles just fine. The only problem with our example is actually that the timestamps aren't being parsed correctly due to a missing hour component (
01:23.456rather than00:01:23.456like the plugin currently expects).Since both formats appear to be valid, I went ahead and added some code to interpret a missing hour component as 0 hours.
This small change allows the plugin to correctly render the captions in our example, but we've still yet to test segmented captions in a live stream (constantly-changing manifest).
As an aside, some of our segment VTT files are empty (except for the
WEBVTTheader) and throw (harmless) exceptions within the parsing code. I'm going to submit another PR (#492) that will filter out empty segments and cut down on the thrown/logged exceptions because this kind of file is also valid.