Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debian based os support #23

Merged
merged 9 commits into from
Jun 30, 2016
Merged

Add Debian based os support #23

merged 9 commits into from
Jun 30, 2016

Conversation

petems
Copy link
Contributor

@petems petems commented Jun 30, 2016

  • Tested on Ubuntu 16.04 HP Proliant 8 server:
root@homebox:~# puppet apply -e 'include ipmi'
Notice: Compiled catalog for homebox.home in environment production in 0.36 seconds
Notice: /Stage[main]/Ipmi::Install/Package[openipmi]/ensure: created
Notice: /Stage[main]/Ipmi::Install/Package[ipmitool]/ensure: created
Notice: /Stage[main]/Ipmi::Config/Augeas[/etc/default/openipmi]/returns: executed successfully
Notice: /Stage[main]/Ipmi::Service::Ipmi/Service[openipmi]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Ipmi::Service::Ipmievd/Service[ipmievd]: Triggered 'refresh' from 1 events
Notice: Applied catalog in 12.66 seconds
root@homebox:~# ipmitool -I open chassis power status
Chassis Power is on
root@homebox:~# facter os.family
Debian

petems added 5 commits June 30, 2016 20:12
@petems
Add config location parameter
520365c 
* Debian-flavor systems have a different file location than RedHat
@petems
Adds Debian specific specs
f66a6d2
@petems
Uncomment specs for contain_class
54b2b47
@petems
Change package name for Debian
67c4387 
* Caps do matter for APT also
@petems
Remove service manifest
7c06239 
* Not actually being used anywhere
@jhoblitt
Copy link
Owner

Looks like the metadata.json change has a typo.

@jhoblitt jhoblitt mentioned this pull request Jun 30, 2016
Merged
@petems petems force-pushed the add_debian_based_os branch from 352ba6d to b81665e Compare June 30, 2016 21:19
@petems
Copy link
Contributor Author

petems commented Jun 30, 2016

@jhoblitt Just fixed, thanks to JSON lint 👍

@petems
Linting fixes
bcb6843 
* Indentation fix
* Scoping fix
@jhoblitt
Copy link
Owner

@petems Your still my hero. 👍

@jhoblitt jhoblitt merged commit 1da7127 into jhoblitt:master Jun 30, 2016
@petems
Copy link
Contributor Author

petems commented Jun 30, 2016

Thanks for the super quick response 💃

@jhoblitt
Copy link
Owner

Shipped as 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @jhoblitt