java-parser: New entrypoint lexAndParse to return both tokens and CST.
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@max-schaefer can you sign the CLA? |
|
Yep, I'm looking into it (currently checking with my employer whether they are OK with me signing it). |
|
CLA is signed. |
|
Thanks for this addition @max-schaefer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
Provide an entrypoint that exposes both the CST and the underlying token array.
Alternatives
The token array could also be accessed through the
parserobject, which we could export instead, but that seems like an internal implementation detail which perhaps shouldn't be part of the API.Finally, we could consider exporting the lexer, but then if I want to get both the CST and the tokens I have to lex twice, which seems wasteful.