Support receiver parameter in method declaration #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Thanks a lot for the contribution ! I am very sorry for this late reply. I have one comment about the optionality of the comma when using receiver parameters, but otherwise, looks good to me !
It would need to update the printer as well, do you want to have a look @TamasSzigeti ?
| DEF: () => { | ||
| $.SUBRULE($.receiverParameter); | ||
| $.OPTION2({ | ||
| GATE: () => $.LA(1).tokenType !== t.RBrace, |
There was a problem hiding this comment.
Is it really optional ? It does not seems to be possible according to the spec: https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4.1-220
| @@ -508,10 +520,13 @@ function defineRules($, t) { | |||
| GATE: $.BACKTRACK($.receiverParameter), | |||
| DEF: () => { | |||
| $.SUBRULE($.receiverParameter); | |||
| $.CONSUME(t.Comma); | |||
| $.OPTION3({ | |||
| GATE: () => $.LA(1).tokenType !== t.RBrace, | |||
|
This ended up being resolved by #642, so this PR can be closed. |
|
'pologies for the abandoned PR, thanks for fixing it elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
As it says on the tin
Example
Relative issues or prs:
Fixes #607