Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test repository #190

Merged
merged 17 commits into from
May 9, 2019
Merged

Add test repository #190

merged 17 commits into from
May 9, 2019

Conversation

Shaolans
Copy link
Member

@Shaolans Shaolans commented May 7, 2019

I have added some repositories to test and it seems that the plugin can now successfully prettify spring-boot and still be semantically valid.
I also added some fixes.
fix #186

@bd82
Copy link
Contributor

bd82 commented May 7, 2019

I think many test repos need to be removed.
Looks like the PR voters take ~2 hours now...
A voter should take at most 10mins.

https://travis-ci.org/jhipster/prettier-java/pull_requests

@Shaolans
Copy link
Member Author

Shaolans commented May 7, 2019

Yes, that was what I was thinking too.
I will probably remove most of jhipster samples.

@bd82
Copy link
Contributor

bd82 commented May 7, 2019

It may also be possible to run some things in parallel, also trying out circle-ci may also be an option.
When I converted the Chevrotain project from travis to circle-ci it seems as though their containers were much faster...

@Shaolans
Copy link
Member Author

Shaolans commented May 9, 2019

It may also be possible to run some things in parallel

Do you mean running the java-parser and the prettier plugin on the separate jobs or running a job on each test repositories ?
By the way, with our current CI, we are running 3 jobs with node 8, 10 and 11. Is this necessary ?

also trying out circle-ci may also be an option

I think we should migrate the CI to Azure Pipelines since the other repositories are migrated here (travis is not going well).
And according @pascalgrimaud this is for: homogeneity for the JHipster orga and it is as fast as circle ci

Btw, I removed most of repositories to just keep 2 JHipster repositories, Spring-Boot and java design patterns and the build time is now 11-13 minutes.

@bd82
Copy link
Contributor

bd82 commented May 9, 2019

Do you mean running the java-parser and the prettier plugin on the separate jobs or running a job on each test repositories ?

We could have 3 parallel jobs each with a different env variable and each doing a different set of repo checks.

By the way, with our current CI, we are running 3 jobs with node 8, 10 and 11. Is this necessary ?

We should change it to 8/10/12 and it is needed to ensure our code runs on all modern node.js versions.

  • e.g using syntax not supported in old node.js versions.

Btw, I removed most of repositories to just keep 2 JHipster repositories, Spring-Boot and java design patterns and the build time is now 11-13 minutes.

That is better, It is actually ~8 mins for the longest job so its perfectly fine.

@Shaolans Shaolans merged commit 065b002 into jhipster:master May 9, 2019
@Shaolans Shaolans deleted the add_test_repository branch June 11, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinforcing tests for the prettier-plugin-java package
2 participants