Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for automated build #12

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

pascalgrimaud
Copy link
Member

Related to jhipster/generator-jhipster#4119

The Docker Hub project is already configured: https://hub.docker.com/r/jhipster/jhipster-sample-app/

@jdubois : before merging this, can you:

  • Go to settings > Webhooks & services
  • Verify the services: Docker => edit
  • Click [x] active
  • Click on update service
  • Then, accept PR if you're ok :-)
  • Back to Services, Docker must be: ✅ Docker

Thanks in advance!

@jdubois jdubois merged commit 5bec9d0 into jhipster:master Sep 16, 2016
@jdubois
Copy link
Member

jdubois commented Sep 16, 2016

Done! I hope the webhook will work!

@pascalgrimaud
Copy link
Member Author

Thanks Julien, it works! -> https://hub.docker.com/r/jhipster/jhipster-sample-app/builds/
I will test tonight the image

@pascalgrimaud
Copy link
Member Author

Just tested this image on my windows machine at work, and it works perfectly!
docker run -p 8080:8080 -e SPRING_PROFILES_ACTIVE=dev jhipster/jhipster-sample-app:master

Very good news! Thanks @jdubois

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants