Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial command integration to jdl #27152

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 2, 2024

  • move more utilities to lib.

Related to #27135.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member Author

mshima commented Sep 3, 2024

The error happens due to #27136.
We have JDL dependency on parsing JDL definition from command, that depends on Generators for callbacks, that depends on JDL.

JDL -> command -> Generator -> JDL circular dependency cause a module to be re-loaded before it was initialized cause it to be undefined.

@mshima mshima mentioned this pull request Sep 3, 2024
6 tasks
@mshima mshima marked this pull request as draft September 5, 2024 09:53
@mshima mshima marked this pull request as ready for review September 5, 2024 12:46
@DanielFran DanielFran merged commit 0d6404c into jhipster:main Sep 5, 2024
52 checks passed
@mshima mshima deleted the command-jdl branch September 5, 2024 13:53
@mraible mraible added this to the 8.7.1 milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants