Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Update Vue 3.4.x #24728

Merged
merged 3 commits into from
Jan 6, 2024
Merged

[Vue] Update Vue 3.4.x #24728

merged 3 commits into from
Jan 6, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 2, 2024

Fix #24708


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: vue labels Jan 2, 2024
@qmonmert qmonmert force-pushed the vue343 branch 4 times, most recently from 97973d8 to f4fc9db Compare January 3, 2024 21:21
@qmonmert qmonmert marked this pull request as ready for review January 3, 2024 21:21
@qmonmert qmonmert force-pushed the vue343 branch 2 times, most recently from eb0a184 to c1b8c50 Compare January 4, 2024 20:16
@qmonmert qmonmert changed the title [Vue] Vue 3.4.3 [Vue] Vue 3.4.4 Jan 4, 2024
@qmonmert qmonmert force-pushed the vue343 branch 3 times, most recently from 115f292 to 7064299 Compare January 5, 2024 17:26
@DanielFran DanielFran changed the title [Vue] Vue 3.4.4 [Vue] Vue 3.4.5 Jan 5, 2024
@DanielFran DanielFran changed the title [Vue] Vue 3.4.5 [Vue] Update Vue 3.4.x Jan 5, 2024
@qmonmert qmonmert force-pushed the vue343 branch 8 times, most recently from 1ecce2a to 6c9df10 Compare January 5, 2024 21:09
@qmonmert
Copy link
Contributor Author

qmonmert commented Jan 5, 2024

maybe we need originjs/vite-plugin-federation#550 for @originjs/vite-plugin-federation

@mshima
Copy link
Member

mshima commented Jan 5, 2024

maybe we need originjs/vite-plugin-federation#550 for @originjs/vite-plugin-federation

I tried in the past it didn’t work with vite module federation.
I need to try again.
I will try to make it pass.

generators/vue/templates/webpack/webpack.common.js.ejs Outdated Show resolved Hide resolved
generators/vue/templates/vite.config.ts.ejs Outdated Show resolved Hide resolved
generators/vue/templates/vite.config.ts.ejs Outdated Show resolved Hide resolved
@mshima mshima merged commit eb6b9b0 into jhipster:main Jan 6, 2024
32 checks passed
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants