Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure principal claim name for oauth2 #24400

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 29, 2023

related to #24374


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member Author

mshima commented Nov 29, 2023

@mraible I will let you test with your existing application.

@mshima mshima changed the title configure principal claim name configure principal claim name for oauth2 Nov 29, 2023
@mraible
Copy link
Contributor

mraible commented Nov 29, 2023

@mshima I tested this, and it does not fix the issue. I also tried using preferred_username since that's the spelling of the official claim.

@mraible
Copy link
Contributor

mraible commented Nov 30, 2023

I can confirm that this now works with Spring MVC. I did not test it with Spring WebFlux.

Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new project with WebFlux and searched for authentication.name. Since there are no instances, I think we should merge this.

@DanielFran DanielFran marked this pull request as ready for review November 30, 2023 18:43
@DanielFran DanielFran merged commit 4044f17 into jhipster:main Nov 30, 2023
48 checks passed
@mshima mshima deleted the oauth2-principal-name branch November 30, 2023 19:28
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants