Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test node 18/20 and java 17/21 matrix #24200

Merged
merged 4 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/angular.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
with:
workflow-samples-file: angular
applications:
name: ${{ matrix.name }}
name: ${{ matrix.name }} (n${{ matrix.node }}/j${{ matrix.java }})
runs-on: ${{ matrix.os || 'ubuntu-20.04' }}
needs: build-matrix
defaults:
Expand Down Expand Up @@ -102,11 +102,11 @@ jobs:
application-packaging: ${{ matrix.setup-application-packaging }}
- uses: actions/setup-node@v4
with:
node-version: ${{ steps.setup.outputs.node-version }}
node-version: ${{ matrix.node }}
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ steps.setup.outputs.java-version }}
java-version: ${{ matrix.java }}
- uses: jhipster/actions/restore-cache@v0
with:
npm: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/react.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
with:
workflow-samples-file: react
applications:
name: ${{ matrix.name }}
name: ${{ matrix.name }} (n${{ matrix.node }}/j${{ matrix.java }})
runs-on: ${{ matrix.os || 'ubuntu-20.04' }}
needs: build-matrix
defaults:
Expand Down Expand Up @@ -102,11 +102,11 @@ jobs:
application-packaging: ${{ matrix.setup-application-packaging }}
- uses: actions/setup-node@v4
with:
node-version: ${{ steps.setup.outputs.node-version }}
node-version: ${{ matrix.node }}
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ steps.setup.outputs.java-version }}
java-version: ${{ matrix.java }}
- uses: jhipster/actions/restore-cache@v0
with:
npm: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/vue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
with:
workflow-samples-file: vue
applications:
name: ${{ matrix.name }}
name: ${{ matrix.name }} (n${{ matrix.node }}/j${{ matrix.java }})
runs-on: ${{ matrix.os || 'ubuntu-20.04' }}
needs: build-matrix
defaults:
Expand Down Expand Up @@ -102,11 +102,11 @@ jobs:
application-packaging: ${{ matrix.setup-application-packaging }}
- uses: actions/setup-node@v4
with:
node-version: ${{ steps.setup.outputs.node-version }}
node-version: ${{ matrix.node }}
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ steps.setup.outputs.java-version }}
java-version: ${{ matrix.java }}
- uses: jhipster/actions/restore-cache@v0
with:
npm: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export const ADD_SPRING_MILESTONE_REPOSITORY = false;
export const NODE_VERSION = '18.18.2';
export const OPENAPI_GENERATOR_CLI_VERSION = '2.7.0';

export const javaDependencies: Record<string, string> = {
/**
* @type {Record<string, string>}
*/
export const javaDependencies = {
/**
* spring-boot version should match the one managed by https://mvnrepository.com/artifact/tech.jhipster/jhipster-dependencies/JHIPSTER_DEPENDENCIES_VERSION
*/
Expand All @@ -52,9 +55,10 @@ export const ELASTICSEARCH_TAG = '8.7.1';
export const ELASTICSEARCH_IMAGE = 'docker.elastic.co/elasticsearch/elasticsearch';

/**
* @type {Record<string, string>}
* Manually updated docker containers
*/
export const dockerContainers: Record<string, string> = {
export const dockerContainers = {
elasticsearchTag: ELASTICSEARCH_TAG,
elasticsearchImage: ELASTICSEARCH_IMAGE,
elasticsearch: `${ELASTICSEARCH_IMAGE}:${ELASTICSEARCH_TAG}`,
Expand Down
4 changes: 2 additions & 2 deletions test-integration/scripts/00-init-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ fi

# jdk version
if [[ "$JHI_JDK" == "" ]]; then
JHI_JDK=$(grep -o "JAVA_VERSION = '[^']*'" $JHI_HOME/generators/generator-constants.mts | cut -f2 -d "'")
JHI_JDK=$(grep -o "JAVA_VERSION = '[^']*'" $JHI_HOME/generators/generator-constants.mjs | cut -f2 -d "'")
fi

# set correct OpenJDK version
Expand All @@ -92,7 +92,7 @@ if [[ "$JHI_CLI" == "" ]]; then
fi

# node version
JHI_NODE_VERSION=$(grep -o "NODE_VERSION = '[^']*'" $JHI_HOME/generators/generator-constants.mts | cut -f2 -d "'")
JHI_NODE_VERSION=$(grep -o "NODE_VERSION = '[^']*'" $JHI_HOME/generators/generator-constants.mjs | cut -f2 -d "'")

# npm version
JHI_NPM_VERSION=$(grep -o '"npm": "[^"]*"' $JHI_HOME/generators/common/resources/package.json | cut -f4 -d '"')
Expand Down
3 changes: 3 additions & 0 deletions test-integration/scripts/99-write-matrix.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { writeFileSync, readFileSync } from 'fs';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';
import { JAVA_VERSION, NODE_VERSION } from '../../generators/generator-constants.mjs';

const __filename = fileURLToPath(import.meta.url);
const packageRoot = join(dirname(__filename), '../..');
Expand Down Expand Up @@ -39,6 +40,8 @@ writeFileSync(
'setup-entities-sample': sample.entity ?? 'none',
'setup-jdl-entities-sample': sample['jdl-entity'] ?? '',
'setup-jdl-sample': sample['jdl-samples'] ?? '',
java: sample['java'] ?? JAVA_VERSION,
node: sample['node'] ?? NODE_VERSION,
}));
} catch (error) {
console.log(`File ${file} not found`, error);
Expand Down
41 changes: 29 additions & 12 deletions test-integration/workflow-samples/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,22 @@
"name": "ng-default-additional",
"entity": "none",
"app-sample": "ng-default",
"jdl-entity": "*"
"jdl-entity": "*",
"node": "20",
"java": "21"
},
{
"name": "ng-mysql-es-noi18n-mapsid",
"app-sample": "ng-mysql-es-noi18n-mapsid",
"entity": "sql"
"entity": "sql",
"node": "20"
},
{
"name": "ng-mongodb-kafka-cucumber",
"app-sample": "ng-mongodb-kafka-cucumber",
"entity": "mongodb",
"environment": "dev"
"environment": "dev",
"java": "21"
},
{
"name": "ng-h2mem-ws-nol2",
Expand All @@ -44,21 +48,25 @@
{
"name": "ng-gradle-fr",
"app-sample": "ng-gradle-fr",
"entity": "sql"
"entity": "sql",
"node": "20",
"java": "21"
},
{
"name": "ng-gradle-mariadb-oauth2-infinispan",
"app-sample": "ng-gradle-mariadb-oauth2-infinispan",
"entity": "sql",
"environment": "dev"
"environment": "dev",
"node": "20"
},
{
"name": "ng-gradle-h2disk-ws-nocache",
"app-sample": "ng-gradle-h2disk-ws-nocache",
"entity": "sql",
"environment": "dev",
"packaging": "war",
"testcontainers": "false"
"testcontainers": "false",
"java": "21"
},
{
"name": "ng-webflux-mongodb",
Expand All @@ -70,7 +78,9 @@
"name": "ng-webflux-gradle-mongodb-oauth2",
"skip-backend-tests": "mongodb's reactive driver deadlocks with junit tests",
"app-sample": "webflux-mongodb-oauth2",
"entity": "mongodb"
"entity": "mongodb",
"node": "20",
"java": "21"
},
{
"name": "ng-webflux-psql-default",
Expand All @@ -79,19 +89,23 @@
},
{
"name": "ng-webflux-psql-additional",
"jdl-samples": "webflux-psql,custom-domain"
"jdl-samples": "webflux-psql,custom-domain",
"node": "20",
"java": "21"
},
{
"name": "ng-webflux-gradle-session-h2mem-es",
"app-sample": "webflux-gradle-session-h2mem-es",
"environment": "dev",
"entity": "sqllight"
"entity": "sqllight",
"node": "20"
},
{
"name": "ng-webflux-couchbase",
"disabled": "needs adjusts for sb3",
"app-sample": "webflux-couchbase",
"entity": "couchbase"
"entity": "couchbase",
"java": "21"
},
{
"name": "ms-ng-consul-oauth2-mongodb-caffeine",
Expand All @@ -103,13 +117,16 @@
"name": "mf-ng-eureka-jwt-psql-ehcache",
"jdl-samples": "mf-ng-eureka-jwt-psql-ehcache",
"extra-args": "--workspaces --monorepository",
"workspaces": "true"
"workspaces": "true",
"node": "20",
"java": "21"
},
{
"name": "ms-mf-ng-consul-oauth2-neo4j",
"jdl-samples": "ms-mf-ng-consul-oauth2-neo4j",
"extra-args": "--workspaces --monorepository",
"workspaces": "true"
"workspaces": "true",
"node": "20"
}
]
}
12 changes: 8 additions & 4 deletions test-integration/workflow-samples/react.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,28 @@
"name": "react-maven-h2mem-memcached",
"app-sample": "react-maven-h2mem-memcached",
"entity": "sql",
"environment": "dev"
"environment": "dev",
"node": "20",
"java": "21"
},
{
"name": "react-gradle-mysql-es-noi18n-mapsid",
"app-sample": "react-gradle-mysql-es-noi18n-mapsid",
"entity": "sql",
"gradle": 1
"node": "20"
},
{
"name": "react-gradle-cassandra-session-redis",
"app-sample": "react-gradle-cassandra-session-redis",
"entity": "cassandra"
"entity": "cassandra",
"java": "21"
},
{
"name": "ms-react-consul-jwt-cassandra-redis",
"jdl-samples": "ms-react-consul-jwt-cassandra-redis",
"extra-args": "--workspaces --monorepository",
"workspaces": "true"
"workspaces": "true",
"java": "21"
},
{
"name": "ms-mf-react-eureka-oauth2-mariadb-infinispan",
Expand Down
10 changes: 7 additions & 3 deletions test-integration/workflow-samples/vue.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,22 @@
{
"name": "vue-noi18n-mysql-ws-oauth2",
"app-sample": "vue-noi18n-ws-oauth2",
"entity": "sqlfull"
"entity": "sqlfull",
"node": "20",
"java": "21"
},
{
"name": "vue-fulli18n-mysql-es",
"app-sample": "vue-fulli18n-es",
"entity": "sql"
"entity": "sql",
"node": "20"
},
{
"name": "vue-gradle-h2mem-ws-session",
"app-sample": "vue-gradle-ws-session",
"entity": "sql",
"environment": "dev"
"environment": "dev",
"java": "21"
},
{
"name": "vue-h2disk-ws-theme",
Expand Down