Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add String.valueof() for correct log message #23455

Merged
merged 2 commits into from
Sep 10, 2023
Merged

add String.valueof() for correct log message #23455

merged 2 commits into from
Sep 10, 2023

Conversation

Farley-Chen
Copy link
Contributor

@Farley-Chen Farley-Chen commented Sep 9, 2023

Fix #21304

logger.error() may not work rightly with logback, because the cause is a exception.
Maybe use String.valueof() to wrap the cause.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

…LoggingAspect.java.ejs

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@DanielFran
Copy link
Member

Thanks @Farley-Chen for the contribution

@DanielFran DanielFran merged commit 663d96b into jhipster:main Sep 10, 2023
47 checks passed
@deepu105 deepu105 added this to the 8.0.0-rc.1 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoggingAspect code generated may not print cause when error
4 participants