Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Account resource test #23117

Merged
merged 11 commits into from
Aug 12, 2023
Merged

Conversation

dinu0000
Copy link
Contributor

@dinu0000 dinu0000 commented Aug 9, 2023

fix #21217

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@deepu105
Copy link
Member

deepu105 commented Aug 9, 2023

My brother @dinu0000 is learning programming so I suggested he work on some JHipster stuff :P

@DanielFran DanielFran marked this pull request as draft August 9, 2023 18:13
@dinu0000 dinu0000 marked this pull request as ready for review August 10, 2023 16:00
@deepu105
Copy link
Member

@dinu0000 my bad. Seems like these needs to be integration Tests as DB is needed when running the tests with -Pprod so I'll revert that change

@deepu105
Copy link
Member

deepu105 commented Aug 11, 2023

While testing this I noticed something weird. For a reactive app with Session based auth, when you hit http://localhost:8080/api/account you get an empty response with status 200 (this is whats causing the ng-webflux-gradle-session-h2mem-es test to fail as it expects 401 like in JWT and Oauth2 case) @mshima @DanielFran @mraible @atomfrede do you have any idea?

image

deepu105
deepu105 previously approved these changes Aug 11, 2023
@deepu105 deepu105 merged commit 80e4394 into jhipster:main Aug 12, 2023
47 checks passed
@dinu0000
Copy link
Contributor Author

@atomfrede
Copy link
Member

While testing this I noticed something weird. For a reactive app with Session based auth, when you hit http://localhost:8080/api/account you get an empty response with status 200 (this is whats causing the ng-webflux-gradle-session-h2mem-es test to fail as it expects 401 like in JWT and Oauth2 case) @mshima @DanielFran @mraible @atomfrede do you have any idea?

image

No idea. Would need to dig deeper.

@deepu105 deepu105 added this to the 8.0.0-beta.3 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccountResourceIT for OAuth2 is confusing
4 participants