Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup one todo method #21617

Merged
merged 4 commits into from
Apr 3, 2023
Merged

cleanup one todo method #21617

merged 4 commits into from
Apr 3, 2023

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Mar 29, 2023

Remove one generator-base-todo method.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be dropped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that review: my TS skill has grown up a bit!
some needle client's methods are always used: I'll clean them one by one in further PRs

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@mshima mshima merged commit f50cf02 into jhipster:main Apr 3, 2023
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants