New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted all the needed functions from base-private #20286

Merged

Tcharl merged 69 commits into jhipster:main from Tcharl:debt

Jan 24, 2023

Contributor

Tcharl commented Nov 11, 2022 •

edited

Loading

Fix remarks from #20151

Contributes to #20295

Please make sure the below checklist is followed for Pull Requests.

All continuous integration tests are green
Tests are added where necessary
The JDL part is updated if necessary
jhipster-online is updated if necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

github-actions bot added the theme: jhipster-internals label

Tcharl mentioned this pull request

First PR - export some methods from the base generator #20151

Merged

6 tasks

Tcharl force-pushed the debt branch 4 times, most recently from f62379a to ee21402 Compare

November 11, 2022 21:32

github-actions bot added theme: docker 🐳 theme: front theme: java labels

Tcharl force-pushed the debt branch from ee21402 to 3a33885 Compare

November 11, 2022 21:48

mshima requested changes

View reviewed changes

generators/base/generator-base-private.mjs Outdated Show resolved Hide resolved

github-actions bot removed theme: front theme: java labels

Tcharl force-pushed the debt branch from efec84a to 34f562d Compare

November 11, 2022 22:37

github-actions bot added the theme: java label

Tcharl force-pushed the debt branch from 34f562d to 3ad9a7f Compare

November 11, 2022 23:18

github-actions bot added theme: front and removed theme: docker 🐳 labels

mshima reviewed

View reviewed changes

generators/base/generator-base-private.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base-private.mjs Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base-private.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs Outdated Show resolved Hide resolved

mshima reviewed

View reviewed changes

generators/base/generator-base.mjs

                  * @param {string} translationKeyMenu - i18n key for entry in the menu
                  */
                 addElementToMenu(routerName, iconName, enableTranslation, clientFramework, translationKeyMenu = _.camelCase(routerName)) {

Member

mshima Nov 12, 2022

Move to the client generator.

Contributor Author

Tcharl Jan 1, 2023

I will, for sure :-)

Contributor Author

Tcharl Jan 8, 2023

I've tried, this one is quite hard to achieve (harder than it seems). I'll do it later in another round (and sorry for that)

Tcharl added 11 commits

January 20, 2023 11:33


          prettier fix

fd873a0


          introduce logguer class

4f1f890


          rewamp logguer

99d3eb9


          use errorHandler externalized method

1fdd773


          use logguer class instead of yeoman log method

701a587


          move some java-formatting method to generator server

a994da0


          extract last base-private method

5efb8a0


          rely on jhipsterConfig instead of this.config on some methods

2d42ef0


          rebased

01b5c97


          improves the checkNode function API

a277d42


          post rebase

3e236f8

Tcharl force-pushed the debt branch from 5d000f2 to 3e236f8 Compare

January 20, 2023 10:49


          [ci-skip] added some javadoc

781a433

Tcharl closed this

Tcharl reopened this

Tcharl dismissed stale reviews from DanielFran and mshima

January 24, 2023 19:02

All changes taken into account

Tcharl enabled auto-merge

January 24, 2023 19:03

Tcharl merged commit 913200a into jhipster:main

This was referenced Jan 25, 2023

drop not necessary handleError #20914

Merged

move optionFromArray implementation locally #20915

Merged

DanielFran changed the title ~~Ready according to previous review - extracted all the needed functions from base-private~~ Extracted all the needed functions from base-private

This was referenced Jan 25, 2023

Move fieldIsEnum and remove getEntityFolderName. #20916

Merged

rework getPkType #20917

Merged

fix logger typo #20918

Merged

remove unused methods #20919

Merged

remove unused methods from generators/utils #20921

Merged

move enum base support to base-application. #20922

Merged

rework doc formating #20981

Merged

DanielFran added this to the 8.0.0-beta.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: angular theme: aws theme: docker 🐳 theme: front theme: Heroku theme: i18n theme: java theme: jhipster-internals theme: kubernetes theme: react theme: upgrade theme: vue