-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove yarn support #12134
Remove yarn support #12134
Conversation
8cf0976
to
083ceff
Compare
Now that NPM is the only choice, can we remove
|
083ceff
to
ef0d610
Compare
@avdev4j what about this one? ef0d610#diff-fddb513f7a2937b33eb1c1f6a71e64a7R2173 ( |
ef0d610
to
9975c55
Compare
oups, my bad :D |
@avdev4j why did you remove the yarn option? |
hi @yuniel-acosta
regards, |
@avdev4j, do we have stats on generation with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with yarn removal, but we should make sure to not conflict with yarn IMO.
Using yarn should be as easy as possible like:
jhipster --client-package-manager yarn
cp my-custom-yarn-package.json package.json
yarn install
I think we should try to:
- move every npm script to package.json
- replace npm calls with packages like
npm show
withlatest-version
- remove npm from every label.
- make sure --skip-install does not call npm.
- keep clientPackageManager for 2 reasons
${clientPackageManager} run ...
and
if(clientPackageManager !== undefined && clientPackageManager !== 'npm') { this.warning('Package manager ${clientPackageManager} is not supported.'); skipInstall = true; }
And may we could try to migrate from yarn-lock to package-lock with @npm/arborist.
generators/upgrade/index.js
Outdated
@@ -204,21 +201,21 @@ module.exports = class extends BaseGenerator { | |||
|
|||
_retrieveLatestVersion(npmPackage) { | |||
this.log(`Looking for latest ${npmPackage} version...`); | |||
const commandPrefix = this.clientPackageManager === 'yarn' ? 'yarn info' : 'npm show'; | |||
const commandPrefix = 'npm show'; | |||
const pkgInfo = shelljs.exec(`${commandPrefix} ${npmPackage} version`, { silent: this.silent }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use lastest-version
package to fetch last version instead of npm show
.
Related: #11925 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure to understand what you want here
test-integration/samples/ngx-gradle-npm-h2disk-ws-nocache/.yo-rc.json
Outdated
Show resolved
Hide resolved
Maybe @jdubois can help us to answer that, or anyone else? @jhipster/developers |
By the way that v7 Roadmap is more a wish list to me, every contributor added his opinion to it. |
This why I added an issue for that and where we should discuss about it ;). Basically every v7 item roadmap should has an issue linked with, and to provide a place to discuss. (maybe I forgot few :D) |
4b66e31
to
730d44d
Compare
Imo its fine to remove yarn and if someone wants to use yarn they can always do so. The script parts with nom will still work |
6d7a52f
to
75b6d8c
Compare
75b6d8c
to
c7a8c6f
Compare
Thanks @avdev4j!! |
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.