Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump generator-jhipster to v8.1.0 #102

Merged
merged 2 commits into from
Dec 19, 2023
Merged

bump generator-jhipster to v8.1.0 #102

merged 2 commits into from
Dec 19, 2023

Conversation

hide212131
Copy link
Contributor

@hide212131 hide212131 commented Dec 12, 2023 •
edited by DanielFran
Loading

@hide212131
Copy link
Contributor Author

Failure of MailServiceIT in gradle

Perhaps this issue is related. MailServiceIT uses @MockBean internally.
Support Mockito with @MockBean and @SpyBean in AOT-processed tests

@hide212131
Copy link
Contributor Author

It was found that by adding @DisabledInAotMode, the said test could be avoided.

@hide212131 hide212131 force-pushed the jhipster-8.1 branch 4 times, most recently from aabeaa0 to 9ec36ea Compare December 18, 2023 22:58
@hide212131 hide212131 marked this pull request as ready for review December 19, 2023 03:06
@hide212131 hide212131 mentioned this pull request Dec 19, 2023
Closed
mshima
mshima approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and the bug looks valid without an clear workaround.

@mshima mshima merged commit e51996c into jhipster:main Dec 19, 2023
26 checks passed
@hide212131 hide212131 deleted the jhipster-8.1 branch December 19, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

@mraible mraible Awaiting requested review from mraible

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hide212131 @mshima