Skip to content

Commit

Permalink
Add symbol container to cli
Browse files Browse the repository at this point in the history
Summary: Adds the ability to pull symbol, dyld shared cache files from a device now that there is an implementation for devices.

Reviewed By: jbardini

Differential Revision: D33422844

fbshipit-source-id: 714948417ab8536338b7b90825058a456ed5b578
  • Loading branch information
lawrencelomax authored and facebook-github-bot committed Jan 5, 2022
1 parent fea9e0f commit 178ef6c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions idb/cli/commands/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ def add_parser_arguments(self, parser: ArgumentParser) -> None:
FileContainerType.FRAMEWORK,
"Use the container of installed frameworks",
),
(
FileContainerType.SYMBOLS,
"Use the container of target-provided symbols/dyld cache",
),
],
)
super().add_parser_arguments(parser)
Expand Down
1 change: 1 addition & 0 deletions idb/common/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ class FileContainerType(Enum):
PROVISIONING_PROFILES = "provisioning_profiles"
ROOT = "root"
SPRINGBOARD_ICONS = "springboard_icons"
SYMBOLS = "symbols"
WALLPAPER = "wallpaper"
XCTEST = "xctest"

Expand Down
2 changes: 2 additions & 0 deletions idb/grpc/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,6 @@ def container_to_grpc(container: FileContainer) -> GrpcFileContainer:
return GrpcFileContainer(kind=GrpcFileContainer.DSYM)
if container == FileContainerType.FRAMEWORK:
return GrpcFileContainer(kind=GrpcFileContainer.FRAMEWORK)
if container == FileContainerType.SYMBOLS:
return GrpcFileContainer(kind=GrpcFileContainer.SYMBOLS)
return GrpcFileContainer(kind=GrpcFileContainer.NONE)

0 comments on commit 178ef6c

Please sign in to comment.