Fix element classNames/ids for objects when using classIdPrefix property #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classIdPrefix would previously add the '.className' version of the class to both the style class and the rendered react component. Instead only include the prefix (. or #) for the style, not the actual elements.
|
I had the same issue as well and this fixes it. It would be great to merge it(if it doesn't break anything else), until then I'll use the fork from @samshelley. Thanks. |
|
Duoh! Dumb mistake on my part. I'll rev a patch version in a day, or so. |
|
Merged and published v0.4.5 |
|
Awesome, thanks @jhamlet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jhamlet, thanks for making this loader!
I'm taking advantage of the classIdPrefix property as I have multiple auto-generated svgs with conflicting class names being loaded into the same file and ran into an issue where the class styles are not showing up in my application. I think the issue is because the "." is included in both the style names and in the actual class property for the rendered element.
This PR seemed to fix the issue for me -- although not sure if this is actually the right way to go about fixing it. (it assumes the styles are calculated sequentially prior to the elements, but I think that's already assumed given the cache?) Let me know if there's a better way to do this.
I also updated the test to match the new output.