Fixes #490: Removes padding-related directives for .delete nested selectors #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components and elements that needs their own padding directives. The inherited padding for nested .delete caused no problems for desktop browsers, because their user agent stylesheets have overriding directives for padding for the relevant <button>, etc. But on iOS Safari there are no such directives. Fixes jgthms#490.
|
I'm not sure in which case the In any case, the reset should be set on |
|
Used instead of tag to fix on ipad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padding is inherited by delete selectors inside components and elements that need their own padding directives.
The inherited padding for nested .delete cause no problems for
desktop browsers, because their user agent stylesheets have
overriding directives for padding for the relevant , etc.
But on iOS Safari there are no such directives.
Fixes #490.
Proposed solution
Fixes weird delete element appearances (elongated from top-left to bottom-right) when delete element inside tag, notification, or message.
Tradeoffs
I don't know. I don't see any padding directives that are relevant for .delete elements, so I thought zeroing out the padding directives was the best way forward.
Testing Done
Solution confirmed via xCode iOS Safari simulator; no regression on macOS Chrome desktop browser.