Fix select icon brightening on label hover #4012
Open
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement, maybe a bug fix.
Given the code below, when hovering over the corresponding label, the icon next to the select does not change to a brighter color. It works for input combinations, but not select.
Proposed solution
Add
&:has(select:hover)to icon color code.Resulting in the following fix:
Tradeoffs
The solution does create some junk, since the
inputandselectclasses are grouped together.Testing Done
Added the fix (as CSS) to an app I'm currently working on. Looks good.
Changelog updated?
No.