Add is-centered|right modifiers to .tags
#1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgthms
requested changes
Nov 4, 2017
sass/elements/tag.sass
Outdated
| @@ -8,6 +8,16 @@ $tag-delete-margin: 1px !default | |||
| display: flex | |||
| flex-wrap: wrap | |||
| justify-content: flex-start | |||
| &.is-centered | |||
There was a problem hiding this comment.
Can you move these after &.has-addons?
jgthms
requested changes
Nov 5, 2017
jgthms
approved these changes
Nov 5, 2017
|
Thanks! That's great. |
jgthms
pushed a commit
that referenced
this pull request
Nov 6, 2017
* add classes * add to changelig * move to appropriate place * more specific margins
|
Just a question but does this work? I was trying to use it in my div for tags but it doesn't seem to be pulling them to the right |
|
@vybhavb sure is, check out this Codepen for an example of it in action: https://codepen.io/timacdonald/pen/QVVoLw |
|
@timacdonald hmm interesting. I have a div inside a panel-block. Not sure if that's what is causing it not to work but none of my tags get pushed right. Heres an example codepen: https://codepen.io/vybhavb/pen/mGGoea |
|
ahhh, yup, you'll need to throw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature.
Proposed solution
This allows
.tags .taggroups to be aligned centre and aligned right. Currently they are only aligned left.Tradeoffs
None come to mind.
Testing Done
Currently doing this in production, works great. Also, here is a codepen I created to show the feature.