Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove black line from progress bar in IE #1342

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

rafeememon
Copy link
Contributor

@rafeememon rafeememon commented Oct 19, 2017

This is a bugfix for inconsistent progress bar styling in IE.

Proposed solution

This PR removes the border from the ::-ms-fill pseudo-element of the progress bar. The problem and solution are discussed in this SO post: https://stackoverflow.com/questions/21780059/why-are-my-progress-bars-displaying-incorrectly-in-ie

Fixes #1340.

Tradeoffs

This adds one additional declaration to the build, but improves support for IE.

Testing Done

I built my branch of Bulma locally, added it to my project, and confirmed that the progress bar looks as intended.

Before fix:

progress_ie

After fix:

progress_ie_fixed

@jgthms jgthms merged commit 19773cd into jgthms:master Oct 22, 2017
@rafeememon rafeememon deleted the remove-progress-black-line branch October 22, 2017 17:14
@rafeememon
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar has erroneous black line in IE11
2 participants