Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar colors in IE #1334

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

rafeememon
Copy link
Contributor

@rafeememon rafeememon commented Oct 18, 2017

This is a bugfix for progress bar colors in IE.

Proposed solution

This PR adds the necessary ::-ms-fill declarations to style the progress bar in IE, as explained here: https://developer.mozilla.org/en-US/docs/Web/CSS/::-ms-fill

Fixes #1333.

Tradeoffs

This slightly increases the size of the build, but improves support for IE. There are other -ms-* declarations in the code base so I think it is reasonable to add this.

Testing Done

I built my branch of Bulma locally, added it to my project, removed my workaround, and confirmed that the progress bar color can be changed:

ie_progress_fixed

@jgthms jgthms merged commit 8724ea3 into jgthms:master Oct 19, 2017
@rafeememon rafeememon deleted the fix-ie-progress-color branch October 19, 2017 13:41
@rafeememon
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar color cannot be changed in IE11
2 participants