Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: is-expanded to navbar-item #1255 #1320

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Add feature: is-expanded to navbar-item #1255 #1320

merged 2 commits into from
Oct 26, 2017

Conversation

doatech
Copy link
Contributor

@doatech doatech commented Oct 16, 2017

This is an improvement.

Added .is-expanded modifier for navbar-item suggested in #1255

Proposed solution

This is a PR for issue #1255 using basic solution suggested by jgthms.

Testing Done

Done locally using Laravel 5.5's default mix npm run dev & npm run prod

@doatech doatech mentioned this pull request Oct 16, 2017
@jgthms
Copy link
Owner

jgthms commented Oct 18, 2017

Just need to fix the changelog conflict.

@doatech
Copy link
Contributor Author

doatech commented Oct 18, 2017

@jgthms fixed!

@jgthms jgthms merged commit cddf871 into jgthms:master Oct 26, 2017
jgthms pushed a commit that referenced this pull request Nov 6, 2017
@amir20
Copy link

amir20 commented Feb 18, 2018

@jgthms I came to this issue and tried using .is-expanded on .navbar-item. However, it wasn't working. After some debugging, I realized .navbar-start doesn't have a size so the flex box was never growing. Do you know what needs to happen to .navbar-start for this to work?

@doatech
Copy link
Contributor Author

doatech commented Feb 19, 2018

@amir20 I suggest adding flex-grow: 1; flex-shrink: 1; to your .navbar-start, but that will make the .navbar-start expanded too. Or maybe use just .navbar-item-s without .navbar-start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants