Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1235 , add one-fifth column #1247

Merged
merged 6 commits into from
Oct 18, 2017
Merged

Fix #1235 , add one-fifth column #1247

merged 6 commits into from
Oct 18, 2017

Conversation

Naskalin
Copy link
Contributor

@Naskalin Naskalin commented Sep 30, 2017

fix this #1235 , add one-fifth column
This is really useful, for example, when you need to show more data for width fullHd (but not <div class="column is-2-fullhd"></div> for 6 column in row)

<div class="columns is-multiline">
    <div class="column 
                is-half-tablet 
                is-one-third-desktop 
                is-one-quarter-widescreen 
                is-one-fifth-fullhd"></div>
    <!--column-->
    <!--column-->
    <!--column-->
    <!--...-->
</div>

add one-fifth column
@Naskalin Naskalin mentioned this pull request Sep 30, 2017
@jgthms
Copy link
Owner

jgthms commented Oct 3, 2017

You would also need two-fifths three-fifths and four-fifths, like the other classes. But that would add a lot of code, hence why I didn't want to add it in the first place.

@Naskalin
Copy link
Contributor Author

Naskalin commented Oct 5, 2017

Ok, I understand, pr updated: add two-fifths three-fifths and four-fifths

@jgthms
Copy link
Owner

jgthms commented Oct 7, 2017

Thanks! Can you update the Changelog and the Docs as well?

update doc / columns
update changes
@Naskalin
Copy link
Contributor Author

Naskalin commented Oct 9, 2017

Synced with master branch. Update Docs and Changelog.

@jgthms jgthms merged commit 85d1a0c into jgthms:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants