-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't forget about RTL direction please #6
Comments
I don't have any experience in implementing RTL in CSS, but I'd be glad if you could help us out. |
I'll try |
When using as much of flexbox's features as possible, and no attributes with "left" or "right" in it, most stuff will "just work". But for example, right now the grid system contains |
It's a great idea @msikma |
It's definitely a bit of work to get RTL working correctly but I think it shouldn't be too bad. 😀 For example, for the columns, if you give every column (This is the same approach used by many other systems, like Bootstrap.) This is best done sooner rather than later since this will break people who have built complex site designs on top of the grid system as it currently is. |
If you want to implement RTL please use conditionals in code instead of using a npm tool. |
Could you explain what you mean by npm tool or conditionals? I'm not entirely sure what you mean. In my idea there should be a single codebase that works for |
@msikma This is an npm tool for example(The best one actually): https://github.com/MohammadYounes/rtlcss |
@msikma Semantic UI(a giant framework) for example uses npm rtl packages instead of using conditionals in css preprocessor. |
I don't think there's a need for conditionals at all. It's perfectly possible (in fact, beneficial) for a CSS framework to support LTR and RTL at the same time, and even without overrides or selectors that include The trick is (mostly) making sure not to use any styling that explicitly favors left or right. |
"The trick is (mostly) making sure not to use any styling that explicitly favors left or right." Seems like a pretty big trick. Semantic UI is awesome. almost good enough for me to switch to less. I'm hoping this project will surpass it.. Let me know if I can help out... |
you can include a a java script code that convert every "left" in the class to "right" , and every "right" to "left" . and adding |
But this isn't a js framework. |
I know, it just could be a simple and fast solution for those who want an RTL version 😄 |
should be able to set offsets from right |
Any progress on this front? Bulma looks really promising and I think RTL support will be a huge win. Starting a new project and absence of RTL support is the only thing stopping me from using it. |
I implemented this feature and will send PR when I tested everything. |
Also we may need to update docs text according to RTL support
here is my fork you can use it by npm install bulma-rtl currently you can use it with sass modules only give me a few hours and I will update this fork with latest bulma changes and I may send another PR with a different approach. otherwise if the Bulma repo maintainers don't want to merge this PR then you can use bulma-rtl from tomorrow and so on... I try to fix rtl related issues there. let me know your thoughts. also I may do some tweaks and add some custom components later if I have time. https://github.com/mohammadrafigh/bulma-rtl P.S. if repo maintainers decide to use my approach I will un-publish bulma-rtl. I just did it to help others like me waiting from 2016 till now. |
@mohammadrafigh need a new bulma rtl for 0.6 version , plzzzz |
@mrjk990 I will do it tonight. but please make issues for this requests on the RTL repo thanks. |
@mohammadrafigh ok i'll , but give me the link to add issue |
@mrjk990 I updated the repo to 0.6.1 here is the link I mentioned above: https://github.com/mohammadrafigh/bulma-rtl you can use bulma-rtl as package name to install it. |
@mohammadrafigh thank you bro 😘 |
Any idea why this is not added into Bulma core? |
@spacemudd this approach won't work in bidi context, i.e. [dir=auto]. also this way user is forced to use dir=rtl on html elements all the time. |
@spacemudd I really see For futuristic browsers support only, see: https://developer.mozilla.org/en-US/docs/Web/CSS/:dir |
I have read about CSS Logical Properties and Values, which I think is THE solution for all RTL problems. Its already been supported in all major browsers except for MS ( which they plan to implement it as it stated here - the response was in 2015 so who knows when they will start! ). Other than this, I don't see any better solution than having a separate More info about CSS Logical Properties and RTL in here. |
Ok, huge news! MS is currently being rebuilt as a Chromium-based browser. Which means, we can expect all features and functionality of other Chromium-powered browsers brought to Edge. Edge will also be released to older windows versions like win7 !! so, CSS Logical Properties and Values is coming in 2019! |
@Rux77 Great! But I think IE is still a problem. I wish it support get dropped soon. People should learn to adapt, and we should help them as well. |
I think that Bulma should not be focused to support old browsers like IE. Bulma should always support modern technologies and modern browsers. If someone wants the support of older browsers should use bootstrap or something else. As for IE browser being dropped, I don't think MS will do such action, at least not in the near future. |
Hey guys, I have seen that styling the body like this: body.ar {
direction: rtl;
} works very well, except for the navbar. Anyone else getting the same result? The navbar gets weird, instead of being like this but in the opposite direction: & It acts like this: & Possible answerI have seen this answer on Stackoverflow:
But it doesn't work.. maybe because I'm not the doing the right steps. Could anyone try this approach or something easy and similar? Stackoverflow answer -> Source |
Nah, I'm not; I'm using the CDN. |
Check this guide for a proper RTL implementation |
I just opened a PR: #2882 |
Thanks @jgthms, So I will mark my fork at https://github.com/mohammadrafigh/bulma-rtl as deprecated and will remove the package from npm soon. |
Thank you @mohammadrafigh for supporting RTL all this time! I think with the popularity of CSS logical properties, Bulma is ready to support RTL. I'd be interested to know your thoughts on my implementation of RTL, and if anything can be improved. |
@jgthms my pleasure. I had a look at PR and now I see it's going to be in the right direction. It's perfect. Yes css logical properties are great. |
Hi |
Any update on this? |
I think we should use start/end instead of left/right. it makes more sense specially in flexbox concept |
I definitely agree with you. All major browsers are supporting
*-inline-start and *-inline-end. This will make things a lot easier.
…On Fri, Sep 30, 2022, 9:55 PM blue-range ***@***.***> wrote:
I think we should use start/end instead of left/right. it makes more sense
specially in flexbox concept
—
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTM4ZE3NLHN5MO34STF4DTWA4WBRANCNFSM4BZY3QXA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.
The text was updated successfully, but these errors were encountered: