Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBE_PING should extend TCPPING #23

Closed
slaskawi opened this issue Mar 14, 2017 · 7 comments
Closed

KUBE_PING should extend TCPPING #23

slaskawi opened this issue Mar 14, 2017 · 7 comments
Assignees
Milestone

Comments

@slaskawi
Copy link
Member

To reuse most of the logic there. The fix should also remove the HTTP Servers.

@slaskawi slaskawi added this to the 1.0.0.Alpha1 milestone Mar 14, 2017
@belaban
Copy link
Member

belaban commented Mar 14, 2017

The idea is to use client.getPods() to retrieve all IP addresses of all pods. Then, instead of sending discovery requests to the web servers at 8888, we send them directly to the members at the given bind ports (plus port_range).

This allows us to remove the web server.

The new KUBE_PING2 protocol will probably extend TCPPING, so the logic of the parent class can be reused.

belaban added a commit that referenced this issue Apr 21, 2017
- Made KUBE_PING extends TCPPING (#23)
- Changed masterProtocol to "https" by default
@belaban
Copy link
Member

belaban commented Apr 21, 2017

Done - still needs some testing with minikube

@belaban
Copy link
Member

belaban commented Apr 26, 2017

Tests were successful with Minikube, documentation is in the readme.adoc

@belaban belaban closed this as completed Apr 26, 2017
@tsegismont
Copy link
Contributor

tsegismont commented Apr 28, 2017 via email

@slaskawi
Copy link
Member Author

+1000! that's a tremendous step forward!

@belaban
Copy link
Member

belaban commented Apr 28, 2017

I also tested KUBE_PING on Google Container Engine (GKE), as it works the same as on minikube. Let me know if you find any flaws when testing it yourself.

@tsegismont
Copy link
Contributor

tsegismont commented Apr 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants