-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUBE_PING should extend TCPPING #23
Comments
The idea is to use client.getPods() to retrieve all IP addresses of all pods. Then, instead of sending discovery requests to the web servers at 8888, we send them directly to the members at the given bind ports (plus port_range). This allows us to remove the web server. The new KUBE_PING2 protocol will probably extend |
- Made KUBE_PING extends TCPPING (#23) - Changed masterProtocol to "https" by default
Done - still needs some testing with minikube |
Tests were successful with Minikube, documentation is in the readme.adoc |
Thanks Bela, I'll try it next week.
2017-04-26 19:56 GMT+05:30 Bela Ban <notifications@github.com>:
… Tests were successful with Minikube, documentation is in the readme.adoc
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbltp6Uuduo8eNuJlr-HfB77yCNHthDks5rz1QfgaJpZM4McP_C>
.
|
+1000! that's a tremendous step forward! |
I also tested KUBE_PING on Google Container Engine (GKE), as it works the same as on minikube. Let me know if you find any flaws when testing it yourself. |
Will do. This was required to enable S2I builds with vertx-infinispan.
Thank you for looking into this!
2017-04-28 16:37 GMT+05:30 Bela Ban <notifications@github.com>:
… I also tested KUBE_PING on Google Container Engine (GKE), as it works the
same as on minikube. Let me know if you find any flaws when testing it
yourself.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbltsfVS8FHdbk4MZDVv9vYX5QLnOvWks5r0ch9gaJpZM4McP_C>
.
|
To reuse most of the logic there. The fix should also remove the HTTP Servers.
The text was updated successfully, but these errors were encountered: